Which professions suit a Shadow Priest: our pick, then each guide's.
Our pick: Tailoring + Enchanting
Recommendation
Tailoring needs no gathering partner and crafts specialized cloth sets; Enchanting enchants your own rings (Spell Power). Herb/Alch if you would rather fund yourself with consumables.